Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5455 - Move Lydd (LZD) NDB #5457

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

lyraongithub
Copy link
Contributor

@lyraongithub lyraongithub commented Sep 10, 2024

Fixes #5455

  • Moved Lydd (LZD) NDB

  • Amend changelog

@PLM1995 PLM1995 changed the title Fixes #5455 - Move EGMD NDB Fixes #5455 - Move Lydd (LZD) NDB Sep 10, 2024
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, you don't want to acreit name in the Changelog too? Just your GitHub thing?

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@PLM1995 PLM1995 added on-hold Pending scenery updates or an effective date airac AIP-related changes labels Sep 10, 2024
@PLM1995 PLM1995 added this to the 2411 milestone Sep 10, 2024
@lyraongithub
Copy link
Contributor Author

lyraongithub commented Sep 10, 2024

Just checking, you don't want to acreit name in the Changelog too? Just your GitHub thing?

Correct. (Hope that's alright.)

Just to be very pedantic and have the name of the NDB, rather than ICAO of nearby airport. :)

Ah, looking at other pull requests, I was unsure which to use. I'll keep that in mind in future.

Co-authored-by: Peter Mooney <61326713+PLM1995@users.noreply.github.com>
@PLM1995
Copy link
Collaborator

PLM1995 commented Sep 20, 2024

@lyraongithub Just realised, this PR isn't linking to the issue as your description doesn't follow the PR standard format and include the keyphrase "Fixes #....", I'll ammend this for you, but just for future, please use the PR template (I think it should do this automatically when you open a PR).

@PLM1995 PLM1995 removed the on-hold Pending scenery updates or an effective date label Oct 2, 2024
@PLM1995 PLM1995 merged commit 8eee9ac into VATSIM-UK:main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airac AIP-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lydd (EGMD) NDB moved
3 participants